Update defunct code#289
Merged
Merged
Conversation
* compiler/modules/multibank.py (multibank) [compute_sizes]: Fix syntax error.
The few Python 2 statements are replaced with their modern counterparts. These are one of the following: - print() function calls (instead of statements), - Exception and Error raising, - passing/receiving tuples as function/lambda arguments, - the L suffix for numeral constants. * compiler/gdsMill/pyx/box.py, compiler/gdsMill/pyx/connector.py, compiler/gdsMill/pyx/deformer.py, compiler/gdsMill/pyx/dvifile.py, compiler/gdsMill/pyx/epsfile.py, compiler/gdsMill/pyx/font/afm.py, compiler/gdsMill/pyx/font/t1font.py, compiler/gdsMill/pyx/graph/axis/texter.py, compiler/gdsMill/pyx/graph/axis/tick.py, compiler/gdsMill/sram_examples/cell6tDemo.py, compiler/gdsMill/sram_examples/newcell.py: Modernize syntax.
Collaborator
|
Looks good, though I would probably just remove the defunct Python 2 examples in gdsMill. It's not clear that they work anymore as they aren't in unit tests. |
Collaborator
|
PR should go to dev branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
As previously announced here's the patch that removes defunct (mostly Python 2) code from the codebase